J-HowHuang commented on PR #18920: URL: https://github.com/apache/pinot/pull/18920#issuecomment-5256276243
@Akanksha-kedia Thanks for the change. Storing configs in `metadata.properties` is fine. Do you have a test to ensure any corner case of serialization doesn't break the read of the metadata file? Also, is it possible to try github's stack PR so that you can stack the other two PRs on top of this new `loadMetadataProperties`, `readStoredJsonIndexConfig`, `setStoredJsonIndexConfig` helpers in `BaseIndexHandler`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
