Copilot commented on code in PR #19139:
URL: https://github.com/apache/pinot/pull/19139#discussion_r3696831973
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/IndexCombinationValidationTest.java:
##########
@@ -458,7 +458,7 @@ public void
testForwardIndexDisabledWithDictAndInvertedPasses() {
@Test
public void testRawWithLz4CodecPasses() {
- FieldConfig fc = new FieldConfig(STR_COL, EncodingType.RAW, (IndexType)
null, CompressionCodec.LZ4, null);
+ FieldConfig fc = new FieldConfig(STR_COL, EncodingType.RAW,
(List<IndexType>) null, CompressionCodec.LZ4, null);
Review Comment:
The explicit cast to `(List<IndexType>) null` is no longer needed now that
the singular-IndexType 5-arg `FieldConfig` constructor was removed. Keeping the
cast adds noise and makes these tests harder to read; `null` will resolve to
the `List<IndexType>` overload unambiguously. (Same pattern appears in the
other compression-codec tests in this file.)
##########
pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/function/AvgAggregationFunctionTest.java:
##########
@@ -196,7 +197,7 @@ void
singleKeyAggregationWithSmallNumGroupsLimitDoesntThrowAIOOBE(FieldConfig.En
new TableConfigBuilder(TableType.OFFLINE)
.setTableName("testTable")
.addFieldConfig(
- new FieldConfig("key", encoding, (FieldConfig.IndexType)
null, PASS_THROUGH, null))
+ new FieldConfig("key", encoding,
(List<FieldConfig.IndexType>) null, PASS_THROUGH, null))
Review Comment:
The cast to `(List<FieldConfig.IndexType>) null` is unnecessary here; `null`
already matches the `FieldConfig(String, EncodingType, List<IndexType>,
CompressionCodec, Map)` overload. Removing it improves readability (and the
same cast can be dropped for the other `FieldConfig` constructions in this
test).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
