xiangfu0 commented on code in PR #19139:
URL: https://github.com/apache/pinot/pull/19139#discussion_r3700372686
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/IndexCombinationValidationTest.java:
##########
@@ -458,7 +458,7 @@ public void
testForwardIndexDisabledWithDictAndInvertedPasses() {
@Test
public void testRawWithLz4CodecPasses() {
- FieldConfig fc = new FieldConfig(STR_COL, EncodingType.RAW, (IndexType)
null, CompressionCodec.LZ4, null);
+ FieldConfig fc = new FieldConfig(STR_COL, EncodingType.RAW,
(List<IndexType>) null, CompressionCodec.LZ4, null);
Review Comment:
Agreed, and fixed in #19148 (kept separate so this PR's approval isn't
churned). Dropped across all 6 call sites here, plus
`AvgAggregationFunctionTest` and `OpenStructIndexConfigTest` — the latter has
the same pattern but wasn't touched by this PR.
Confirmed the resolution is unambiguous rather than assuming it: with the
singular-`IndexType` overload gone, the 5-arg form is unique (the remaining
constructors are 7- and 9-arg). Verified by compiling — it fails against a
stale `pinot-spi` and passes when `pinot-spi` is built in-reactor from this
branch, which is also why the fix has to be stacked on this PR rather than
based on master.
##########
pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/function/AvgAggregationFunctionTest.java:
##########
@@ -196,7 +197,7 @@ void
singleKeyAggregationWithSmallNumGroupsLimitDoesntThrowAIOOBE(FieldConfig.En
new TableConfigBuilder(TableType.OFFLINE)
.setTableName("testTable")
.addFieldConfig(
- new FieldConfig("key", encoding, (FieldConfig.IndexType)
null, PASS_THROUGH, null))
+ new FieldConfig("key", encoding,
(List<FieldConfig.IndexType>) null, PASS_THROUGH, null))
Review Comment:
Fixed in #19148. Also removed the now-unused `java.util.List` import this PR
had added solely for these casts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
