yashmayya commented on PR #19140:
URL: https://github.com/apache/pinot/pull/19140#issuecomment-5159941702
One of these looks like it's in the wrong bucket:
`PinotHelixResourceManager.getSchemaForTableConfig` wasn't deprecated in 1.0.0.
At `release-1.3.0` it's still a live method with real fallback logic (look
up the schema by raw table name, then fall back to `schemaName` in the
validation config):
```java
/**
* Find schema with same name as rawTableName. If not found, find schema
using schemaName in validationConfig.
* For OFFLINE table, it is possible that schema was not uploaded before
creating the table. Hence for OFFLINE,
* this method can return null.
*/
@Nullable
public Schema getSchemaForTableConfig(TableConfig tableConfig) {
```
`@Deprecated` first shows up at `release-1.4.0`, added by #15333 (Mar 2025)
when schema became mandatory for all tables. Checking the tags:
```
release-1.0.0 not deprecated
release-1.1.0 not deprecated
release-1.2.0 not deprecated
release-1.3.0 not deprecated
release-1.4.0 deprecated
```
So it's carried the annotation through 1.4.0, 1.5.0 and 1.5.1 — real runway,
and there are no remaining callers, so no objection to removing it. But it's a
shorter window than the "1.0.0" heading implies, and anyone later auditing when
a given API was deprecated would get the wrong answer from the PR title. Might
be worth moving it to a 1.4.0-era PR, or just calling it out separately in the
release notes.
Everything else in this PR checks out as `@Deprecated` at `release-1.0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
