xiangfu0 commented on PR #19140: URL: https://github.com/apache/pinot/pull/19140#issuecomment-5160259250
@yashmayya good catch, you're right and I've confirmed it independently. `getSchemaForTableConfig` is still live with its fallback logic at `release-1.3.0`; `@Deprecated` first appears at `release-1.4.0`, from #15333 as you say. So the "1.0.0" heading is wrong for this one member. Worth naming the root cause, because it could have hidden more than one error: I dated each group by git-blaming a single representative line and assuming its neighbours shared that vintage. Here I blamed `deleteSchema` (deprecated 2023, correctly 1.0.0-era) and inherited that date for `getSchemaForTableConfig` sitting right below it — which was actually deprecated two years later. So I re-ran the check properly across the whole series: for every member removed in all five PRs, does it carry `@Deprecated` at `release-1.3.0`? This is the only one that fails. Everything else is correctly bucketed. I've kept the removal here and called the real vintage out explicitly in the commit message, taking your "call it out separately" option — it's carried the annotation through 1.4.0, 1.5.0 and 1.5.1 and has no remaining callers. Happy to pull it out and hold it for a 1.4.0 sweep instead if you'd rather the buckets stay strictly clean; just say the word. Separately, note the `Pinot Binary Compatibility Check` red X on #19139, #19141 and #19143 — that's japicmp correctly flagging the intended `pinot-spi` removals, and I've listed the exact violations in each PR body. Since there's no allowlist or label bypass in the workflow, I'd appreciate direction on whether you'd prefer those merged over the failing check, or a separate PR adding a sanctioned escape hatch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
