snleee commented on a change in pull request #4737: Druid-Pinot Segment Converter Tool URL: https://github.com/apache/incubator-pinot/pull/4737#discussion_r348118509
########## File path: contrib/pinot-druid-migration/pom.xml ########## @@ -0,0 +1,184 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + + <artifactId>pinot-druid-migration</artifactId> + <groupId>org.apache.pinot</groupId> + <version>0.2.0-SNAPSHOT</version> + <modelVersion>4.0.0</modelVersion> + + <name>Pinot Druid Migration</name> + <url>https://pinot.apache.org/</url> + <dependencies> + <dependency> + <groupId>org.apache.pinot</groupId> + <artifactId>pinot-common</artifactId> + <version>0.2.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>org.apache.pinot</groupId> + <artifactId>pinot-core</artifactId> + <version>0.2.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>org.apache.pinot</groupId> + <artifactId>pinot-tools</artifactId> + <version>0.2.0-SNAPSHOT</version> + </dependency> + <dependency> + <groupId>org.apache.druid</groupId> + <artifactId>druid-processing</artifactId> + <version>0.16.0-incubating</version> + </dependency> + <dependency> + <groupId>org.testng</groupId> + <artifactId>testng</artifactId> + <scope>test</scope> + <version>6.11</version> + </dependency> + </dependencies> + <build> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>appassembler-maven-plugin</artifactId> + <configuration> + <programs> + <program> + <mainClass>org.apache.pinot.druid.tools.DruidToPinotSegmentConverter</mainClass> + <name>pinot-druid-converter</name> + <jvmSettings> + <initialMemorySize>4G</initialMemorySize> + <maxMemorySize>4G</maxMemorySize> + <extraArguments> + <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument> + <extraArgument>-Dlog4j2.configurationFile=test/resources/log4j2.xml</extraArgument> + </extraArguments> + </jvmSettings> + </program> + </programs> + <binFileExtensions> + <unix>.sh</unix> + </binFileExtensions> + + <!-- Set the target configuration directory to be used in the bin scripts --> + <configurationDirectory>conf</configurationDirectory> + <!-- Copy the contents from "/src/main/config" to the target configuration directory in the assembled application --> + <copyConfigurationDirectory>false</copyConfigurationDirectory> + <!-- Include the target configuration directory in the beginning of the classpath declaration in the bin scripts --> + <includeConfigurationDirectoryInClasspath>false</includeConfigurationDirectoryInClasspath> + <assembleDirectory>${project.build.directory}/${project.artifactId}-pkg</assembleDirectory> + <unixScriptTemplate>${project.basedir}/src/main/resources/appAssemblerScriptTemplate.sh</unixScriptTemplate> + <!-- Generate bin scripts for windows and unix pr default --> + <platforms> + <platform>unix</platform> + </platforms> + <repositoryLayout>flat</repositoryLayout> + <repositoryName>lib</repositoryName> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-enforcer-plugin</artifactId> + <version>3.0.0-M2</version> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> + <version>3.8.0</version> + <configuration> + <source>1.8</source> + <target>1.8</target> + <compilerVersion>1.8</compilerVersion> + </configuration> + </plugin> +<!-- <plugin>--> Review comment: Do we need this? Can you clean this part? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
