snleee commented on a change in pull request #4737: Druid-Pinot Segment
Converter Tool
URL: https://github.com/apache/incubator-pinot/pull/4737#discussion_r348262861
##########
File path:
contrib/pinot-druid-migration/src/main/java/org/apache/pinot/druid/tools/DruidToPinotSegmentConverter.java
##########
@@ -31,9 +31,9 @@
public class DruidToPinotSegmentConverter {
private static String _pinotSchemaFilePath;
Review comment:
We usually use either `private` (instance variable) or `private static
final` (constant). Let's actually remove these variables.
We can do either of the followings:
1. Do everything in `main()`
2. Add variables to `convertSegment()` function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
