Vamsi-klu commented on PR #19087: URL: https://github.com/apache/pinot/pull/19087#issuecomment-5322285150
@Jackie-Jiang not all of them yet. A few Copilot comments are stale after the opt-in change, but two are still valid and I had not replied on those threads. I am going to fix those, reply on each comment, and resolve them. On passing schema at the pre-complex-type call: yes, I should pass `schema` instead of `null`. That path still does not auto-register aggregation sources, so behavior stays the same. It is just less confusing. The remaining code fixes: 1. Treat any SourceFieldConfig as covering the column, including preComplexTypeTransform ones, so the explicit type cannot get overwritten after complex type unnest. 2. If one source column is used by more than one aggregation, do not let config order decide the type. Keep the wider numeric type (for example BIG_DECIMAL over DOUBLE) so SUM_PRECISION cannot lose digits. 3. Clean up the precedence test comment (explicit override is INT, auto type is LONG) and turn the flag on in that test. The lazy DataTypeTransformer comment no longer applies. We already removed that path after your note. I will push this next and then resolve the threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
