Vamsi-klu commented on PR #19087: URL: https://github.com/apache/pinot/pull/19087#issuecomment-5365359028
@Jackie-Jiang Review comments are addressed. Please take another look. - Extra conversion is opt-in via convertAggregationSourceTypes (default false) and uses the stock DataTypeTransformer - Pre-complex-type transformer call now passes schema - Any explicit SourceFieldConfig, including pre-complex-type, wins over auto inference - One source feeding multiple aggregations keeps the wider numeric type - Copilot threads are addressed in 41afce92 On Mon, Aug 17, 2026 06:18 PM, "Xiaotian (Jackie) Jiang" < ***@***.***> wrote: > ***@***.**** commented on this pull request. > > Have you addressed all AI comments? If so, please reply and resolve them > ------------------------------ > > In pinot-segment-local/src/main/java/org/apache/pinot/segment/ > local/recordtransformer/RecordTransformerUtils.java > <https://github.com/apache/pinot/pull/19087#discussion_r3800184927>: > > > @@ -74,7 +83,7 @@ public static List<RecordTransformer> getTransformers(TableConfig tableConfig, @ > boolean skipPostComplexTypeTransformers, boolean skipFilterTransformer) { > List<RecordTransformer> transformers = new ArrayList<>(); > if (!skipPreComplexTypeTransformers) { > - addSourceFieldDataTypeTransformer(tableConfig, transformers, true); > + addSourceFieldDataTypeTransformer(tableConfig, null, transformers, true); > > Should you pass schema here? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/19087?email_source=notifications&email_token=AH27ZKBLEO2XJLCDFMKEXQD5KOVFXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJVGYYTSOJXHA3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4956199786>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AH27ZKDAB4K2LT3F3WQOU5L5KOVFXAVCNFSNUABEKJSXA33TNF2G64TZHMYTSOJWGEYDQNJ3JFZXG5LFHM2DSNZUGUZTINZWGWQXMAQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
