Jackie-Jiang commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r348861136
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/virtualcolumn/DefaultNullValueSingleStringVirtualColumnProvider.java
##########
@@ -19,11 +19,10 @@
package org.apache.pinot.core.segment.virtualcolumn;
/**
- * Virtual column provider that returns the current host name.
+ * Provide the default null value as a single string.
*/
-public class HostNameVirtualColumnProvider extends
SingleStringVirtualColumnProvider {
- @Override
+public class DefaultNullValueSingleStringVirtualColumnProvider extends
SingleStringVirtualColumnProvider {
Review comment:
This class is good for this PR. In your following PRs, you might want to
change this class into a general DefaultNullValueVirtualColumnProvider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
