Jackie-Jiang commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r348860184
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/virtualcolumn/VirtualColumnProviderFactory.java
##########
@@ -18,36 +18,47 @@
*/
package org.apache.pinot.core.segment.virtualcolumn;
+import com.google.common.base.Preconditions;
+import org.apache.commons.lang.StringUtils;
import org.apache.pinot.common.data.DimensionFieldSpec;
import org.apache.pinot.common.data.FieldSpec;
import org.apache.pinot.common.data.Schema;
+import static
org.apache.pinot.common.utils.CommonConstants.Segment.BuiltInVirtualColumn;
+
/**
* Factory for virtual column providers.
*/
public class VirtualColumnProviderFactory {
- public static VirtualColumnProvider buildProvider(String
virtualColumnProvider) {
+ public static VirtualColumnProvider buildProvider(FieldSpec fieldSpec) {
Review comment:
This method should be reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
