deepthi912 commented on code in PR #19394:
URL: https://github.com/apache/pinot/pull/19394#discussion_r3899548880
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java:
##########
@@ -158,6 +158,16 @@ public static void preprocess(File indexDir,
IndexLoadingConfig indexLoadingConf
Preconditions.checkArgument(indexDir.isDirectory(), "Index directory: %s
does not exist or is not a directory",
indexDir);
+ // Respect skipSegmentPreprocess uniformly across every caller — including
cold-download load paths
Review Comment:
I see your point, but needPreProcess would open segment directories and
check segment versions as well which we don't need in cases of new segment
generations and also open segment index handlers to check for preProcess when
we can simply assume the worst case and do `preProcess`.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java:
##########
@@ -158,6 +158,16 @@ public static void preprocess(File indexDir,
IndexLoadingConfig indexLoadingConf
Preconditions.checkArgument(indexDir.isDirectory(), "Index directory: %s
does not exist or is not a directory",
indexDir);
+ // Respect skipSegmentPreprocess uniformly across every caller — including
cold-download load paths
Review Comment:
I see your point, but needPreprocess would open segment directories and
check segment versions as well which we don't need in cases of new segment
generations and also open segment index handlers to check for preProcess when
we can simply assume the worst case and do `preProcess`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
