mcvsubbu commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r350344072
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/virtualcolumn/VirtualColumnProviderFactory.java
##########
@@ -35,19 +37,20 @@ public static VirtualColumnProvider buildProvider(String
virtualColumnProvider)
}
}
- public static void addBuiltInVirtualColumnsToSchema(Schema schema) {
- if (!schema.hasColumn("$docId")) {
- schema.addField(new DimensionFieldSpec("$docId", FieldSpec.DataType.INT,
true, DocIdVirtualColumnProvider.class));
+ public static void addBuiltInVirtualColumnsToSegmentSchema(Schema schema,
String hostName, String segmentName) {
Review comment:
remove hostname from the argument, and determine the hostname statically in
this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
