mcvsubbu commented on a change in pull request #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r350343889
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/virtualcolumn/VirtualColumnContext.java
##########
@@ -18,33 +18,23 @@
*/
package org.apache.pinot.core.segment.virtualcolumn;
+import org.apache.pinot.common.data.FieldSpec;
+
+
/**
* Context used to pass arguments to the virtual column provider.
*/
public class VirtualColumnContext {
- private String _hostname;
- private String _segmentName;
- private String _columnName;
+ private FieldSpec _fieldSpec;
Review comment:
This is not related to your PR, but since you are touching it and have some
context, some more comments on what VirtualColumnContext does will be useful.
To me, the class seems to be a miscellaneous class of all things needed for a
virtual column that cannot be determined in other places? If you can add a
better class description that will be awesome, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
