snleee commented on a change in pull request #4737: Druid-Pinot Segment 
Converter Tool
URL: https://github.com/apache/incubator-pinot/pull/4737#discussion_r350360709
 
 

 ##########
 File path: contrib/pinot-druid-migration/README.md
 ##########
 @@ -0,0 +1,61 @@
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+-->
+# Druid to Pinot Segment Converter Tool
+
+This tool takes a local Druid segment and uses it to generate a corresponding 
Pinot segment with all of the columns 
+specified in a given Pinot schema.
+
+## Build and Usage
+To build the project:
+
+```
+mvn clean install -DskipTests
+```
+
+
+This will create `druid-to-pinot-schema-generator-jar-with-dependencies.jar` 
and 
 
 Review comment:
   We should not create multiple jars for each command. This will create 
multiple fat jars that include all necessary dependencies. Fat jars tend to be 
very large (hundreds of megabytes). We should change this to create a single 
jar file and change you main class to be an entry point for the multiple tasks. 
(Please refer to `pinot-admin.sh` from `pinot-tools`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to