xiangfu0 commented on PR #19533: URL: https://github.com/apache/pinot/pull/19533#issuecomment-5649841158
@Jackie-Jiang Confirmed: every production row writer populates every column, including null values. Each setter writes its complete fixed-width slot (or offset/length pair) and sets its own buffer position; `finishRow()` copies the bytes into the output stream. There is no dependency on clearing or resetting the buffer. Addressed in b51ffd1e43467462d34001dcf424f35635d75156: the buffer is now allocated once in the constructor and is final, and `startRow()` only increments the row count. I also documented the complete-row contract and updated the regression test to populate every column, including reverse-order writes, empty variable-length values, explicit nulls, NaN payloads, and signed zero. All 83 focused serde, selection, and GROUP BY tests passed on JDK 25, along with Spotless, Checkstyle, and license checks. Changed-file warning-enabled compilation passed with no warnings on added lines. The existing full warning-enabled reactor compilation issue with the missing `NotNull` dependency is documented in the PR description, and the earlier benchmark results are explicitly labeled as belonging to the previous revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
