xiangfu0 commented on code in PR #19533:
URL: https://github.com/apache/pinot/pull/19533#discussion_r4002691757
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTableBuilder.java:
##########
@@ -65,6 +65,7 @@ public abstract class BaseDataTableBuilder implements
DataTableBuilder {
protected final int _version;
protected final int[] _columnOffsets;
protected final int _rowSizeInBytes;
Review Comment:
Addressed in 4dd42c503588d0f944700d316c58a0b8036df567: removed
`_rowSizeInBytes` from the instance fields and made `rowSizeInBytes` a
constructor-local variable. The value is only needed to allocate the row
buffer, and the sole builder subclass does not use it. All 10
`DataTableSerDeTest` cases and the required Spotless, Checkstyle, and license
checks passed on JDK 25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
