goutamadwant commented on PR #19180: URL: https://github.com/apache/pinot/pull/19180#issuecomment-5708277868
Hi @Jackie-Jiang and @shounakmk219 before I rebase this PR, I’d like to confirm the preferred scope now that #19488 has merged and #19490 is active. #19488 provides the task-specific, opt-in path for same-name segment refreshes and avoids staging/uploading an unchanged segment. That overlaps with the minion executor changes in this PR, but it does not provide the standalone validated API requested in #10458 for custom-map-only ZK metadata updates. Would you prefer that I: 1. Narrow #19180 to the dedicated metadata API only, removing the overlapping minion executor changes. I would address the open feedback by adding authentication, strict request-shape validation, expected-CRC and ZK-version compare-and-set protection, and clearly defined refresh-time behavior; or 2. Close #19180 because #19488 and #19490 sufficiently cover the intended use case? My preference is option 1 if the standalone API is still useful. I’ll wait for confirmation before rebasing so this PR does not duplicate the merged execution path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
