Jackie-Jiang commented on code in PR #19535: URL: https://github.com/apache/pinot/pull/19535#discussion_r4066844952
########## pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java: ########## @@ -409,12 +409,7 @@ protected byte[] serializeStringDictionary() /// Helper method to deserialize dictionary map. protected String[] deserializeStringDictionary(ByteBuffer buffer) Review Comment: This is actually not used. You may delete the ser/de code here. The ser-de is done in `ZeroCopyDataBlockSerde`, where you can apply the same optimization in `deserializeDictionary` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
