xiangfu0 commented on code in PR #19535: URL: https://github.com/apache/pinot/pull/19535#discussion_r4067001894
########## pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java: ########## @@ -409,12 +409,7 @@ protected byte[] serializeStringDictionary() /// Helper method to deserialize dictionary map. protected String[] deserializeStringDictionary(ByteBuffer buffer) Review Comment: Good catch — removed the unused `serializeStringDictionary()`/`deserializeStringDictionary()` from `BaseDataBlock`, and applied the same scratch-buffer reuse in `ZeroCopyDataBlockSerde.deserializeDictionary` (same empty-string / negative-length behavior as `readInt4UTF()`). Added `ZeroCopyDataBlockSerdeTest.testStringDictionary` covering long→short→empty and multi-byte entries through a full serde round trip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
