xiangfu0 commented on code in PR #19477: URL: https://github.com/apache/pinot/pull/19477#discussion_r4148407097
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java: ########## @@ -107,6 +107,11 @@ public class HelixInstanceDataManagerConfig implements InstanceDataManagerConfig public static final String DISABLE_DIMENSION_TABLE_PRELOAD = "disable.dimension.table.preload"; private static final boolean DEFAULT_DISABLE_DIMENSION_TABLE_PRELOAD = false; + // Whether to create the index container and data source of a physical column on first access instead of for every + // column at segment load. Off by default. See InstanceDataManagerConfig#isLazyColumnMaterialization(). + public static final String LAZY_COLUMN_MATERIALIZATION = "segment.lazy.column.materialization"; Review Comment: A companion documentation PR is now open: https://github.com/pinot-contrib/pinot-docs/pull/1080. It adds the default-off server setting, example usage, first-access latency/error trade-off, built-in v1/v2/v3 support, and the concurrency requirement for external SegmentDirectory.Reader implementations. The docs PR should merge with the feature rollout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
