suvodeep-pyne commented on PR #19737: URL: https://github.com/apache/pinot/pull/19737#issuecomment-6050487717
**Update: 9b5a02e24f**: re-ingestion consumption now stops at the next batch even with stream plugins that ignore interrupts. - `StatelessRealtimeSegmentWriter.stopConsumption()` sets a volatile stop flag, and the consumer loop checks it before each fetch. Before, the uninterruptible join from the previous commit could block `close()`, and with it the re-ingestion shutdown, until a plugin that swallowed the interrupt reached the end offset. - A stopped consumption is not successful and records a cause naming the stop. `getConsumptionException()` is now marked `@Nullable`. - New `StatelessRealtimeSegmentWriterTest`, the first unit test for this class. It stops consumption from a fake stream that never reaches the end offset and swallows interrupts. It hung before this change. The PR description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
