suvodeep-pyne commented on PR #19737:
URL: https://github.com/apache/pinot/pull/19737#issuecomment-6049012540
**Update: 13ba976e3a** addresses the second round of review.
- **Shutdown:**
- `ReingestionResource` shuts its executor down when the admin API stops
(`@PreDestroy`). Running jobs are interrupted and clean up, and queued jobs are
dropped and logged.
- Worker threads are daemon threads.
- A `submit` rejected during shutdown returns 503 and clears the
in-progress tracking.
- **Writer cleanup:** `StatelessRealtimeSegmentWriter.stopConsumption()` now
waits for the consumer thread even if interrupted. Before, an interrupt during
`close()` made it stop waiting, and the mutable segment could be destroyed
while the consumer thread was still indexing.
- **Queued jobs:** a job is tracked before it is submitted, so `GET
/reingestSegment/jobs` also lists jobs waiting for a re-ingestion thread.
- **Messages:**
- Wait messages name the segment being consumed, and the timeout message
includes the timeout.
- A config change logs the previous and new timeout, and only when the
value changes.
- **Tests:**
- new endpoint tests for the queued-job listing and the shutdown; both
fail without the fix;
- unique segment names per test;
- a wider timeout on the deadline test so it can't fail spuriously.
The PR description is updated to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
