xiangfu0 commented on PR #19396: URL: https://github.com/apache/pinot/pull/19396#issuecomment-6050622277
@gortiz rebased on master `3a36f13959` and pushed `6f63db504b9858b45707ee13b08a30049ad55910` with the review fixes. All 14 inline requests have individual evidence-backed replies and are resolved. The gate now reads only cached state on an enabled query, and shared incremental live-version tracking replaces the duplicated scanner. Merge exchange/receive are sibling nodes with dedicated visitors; legacy flags are deprecated. The single-run requirement is an explicit serialized hint, unused merge limits are removed, and the merge uses passive receive deadlines. The new hybrid integration test passed through actual planner/proto/opchain/local+gRPC execution, comparing receiver-sort and merge results for ROWS/FOLLOWING and RANGE/peer frames with nulls, duplicate keys and all 32 offline/realtime rows. Other local coverage passed: 968 planner/serde/plan-fixture cases, 177 focused runtime cases, plus tracker/capability/query-option tests. Scoped formatting, license, checkstyle and added-line warning checks passed. For the non-inline comments: the receiver MAX-fetch hardening, 124 JSON plan edits and unrelated annotations dependency are removed; the option/config now use `windowKWayMerge`; the no-op local/wrapper/blank-line leftovers are removed. The description now documents usage, tag 19, the visitors, the SNAPSHOT exclusion and the actual offset semantics. Heap remove/add and single-remaining-stream improvements are left out as the informational performance follow-up, without adding speculative optimization or benchmark code. The feature remains opt-in and the memory limitation tracked by #19395 remains open. This update does not claim universal performance superiority or a validated AUTO selector. Exact-head hosted CI is running; maintainer re-review is still required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
