xiangfu0 commented on PR #19396: URL: https://github.com/apache/pinot/pull/19396#issuecomment-5975636970
@gortiz updated at `01af90617f`. Ordering is now a logical-plan guarantee: an [explicit Sort feeds PinotKWayMergeSortExchange](https://github.com/apache/pinot/blob/01af90617fc8789384187dd9007b40ad642314e7/pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java#L132-L177), and [fragmentation creates a plain sender plus a distinct merge receive](https://github.com/apache/pinot/blob/01af90617fc8789384187dd9007b40ad642314e7/pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/PlanFragmenter.java#L193-L205) with serialized optional fetch/offset. Mailbox block markers, sender structural checks, production row-order checks, and the new merge receiver's full-sort fallback are removed. The [broker gate](https://github.com/apache/pinot/blob/01af90617fc8789384187dd9007b40ad642314e7/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/KWayMergeSupportPredicate.java#L38-L97) requires matching, non-SNAPSHOT broker/server release versions and fails closed on missing/unreadable configs, registration failure or disconnect; multi-cluster queries disable it. Unsupported clusters use plain receive plus an explicit MAX-fetch Sort, preserving complete window input. [Legacy `sort=true` plans still use the deprecated full-sort receiver](https://github.com/apache/pinot/blob/01af90617fc8789384187dd9007b40ad642314e7/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PlanNodeToOpChain.java#L195-L205); its replacement and old-flag cleanup remain follow-up work. The gate is a point-in-time snapshot, so a concurrent version/topology change can still cause a loud unsupported-node query failure. Recent unchanged planner/window coverage passed 962 cases, including full-input following/RANGE regressions. This latest commit only corrects the existing SNAPSHOT assertion (+7/-3 lines); both broker gate tests, JDK25 warning-enabled compilation, formatting, checkstyle and license checks passed, with no warnings on added lines. All 17 reported checks were green at `b047dd4`; CI is running on the new head. Please re-review the architecture and retained legacy compatibility path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
