xiangfu0 commented on code in PR #19795:
URL: https://github.com/apache/pinot/pull/19795#discussion_r4225310936
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/customobject/PercentileTDigestAccumulator.java:
##########
@@ -638,10 +702,44 @@ public int byteSize() {
return serialize().length;
Review Comment:
Addressed in 14657b2cfb. byteSize() retains one serialized result for the
following asBytes() write. State changes invalidate it, and asBytes consumes
it; the regression verifies the cache lifecycle. Compact serialization keeps
its separate sizing/write path. maxSerializedByteSize() remains an allocation
bound without serializing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
