mcvsubbu commented on a change in pull request #4874: Pinot ingestion job -
Standalone
URL: https://github.com/apache/incubator-pinot/pull/4874#discussion_r352868637
##########
File path:
pinot-common/src/main/java/org/apache/pinot/filesystem/PinotFSFactory.java
##########
@@ -43,6 +43,18 @@ private PinotFSFactory() {
}
+ public static void register(String scheme, String fsClassName, Configuration
configuration) {
Review comment:
Can you provide examples of what are the variables that are expected to be
set in Configuration? Or, is the whole thing totally FS dependent? (e.g. do we
expect basedir to be set there?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
