mcvsubbu commented on a change in pull request #4874: Pinot ingestion job - Standalone URL: https://github.com/apache/incubator-pinot/pull/4874#discussion_r352895807
########## File path: pinot-ingestion-jobs/pinot-standalone/src/main/java/org/apache/pinot/ingestion/common/PinotFSSpec.java ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.ingestion.common; + +import java.util.Map; + + +public class PinotFSSpec { + + String _scheme; + + String _className; + + Map<String, String> _configs; + + public String getScheme() { + return _scheme; + } + + public void setScheme(String scheme) { + _scheme = scheme; + } + + public String getClassName() { + return _className; + } + + public void setClassName(String className) { + _className = className; + } + + public Map<String, String> getConfigs() { Review comment: My personal bias is towards NOT using auto-conversion to keep library compatibility, etc. I understand the intention of not having boiler plate code, and too many hard-coded values, but we have been bitten BADLY by incompatible enhancements to these packages, and if there are multiple of them (now yaml as well as json) then we better stick with packages that have a good reputation to keep method signatures etc. backward compatible. That said, I am not sure how to work with yaml trying to represent arbitrary properties that a file system may have. e.g. hadoopfs.baseurl hadoopfs.security.kerberos.whatever hadoopfs.security.kerberos.tokenwhatever etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
