xiangfu0 commented on code in PR #19829:
URL: https://github.com/apache/pinot/pull/19829#discussion_r4251511219
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/customobject/tdigest/PercentileTDigestAccumulator.java:
##########
@@ -50,7 +50,7 @@
/// input must be merged. The raw-value buffer remains unallocated for
serialized state until a raw value is added.
///
/// Instances are externally serialized per aggregation or group key and are
not safe for concurrent mutation.
-final class PercentileTDigestAccumulator extends TDigest {
+public final class PercentileTDigestAccumulator extends TDigest {
Review Comment:
Renamed the relocated class and its callers to `TDigestAccumulator` in
`cda0e45cc8131a1eb86ed53da7344b202c1e22f8`. All six Java files match the
previous source exactly after reversing the identifier substitution; the
algorithm and serialized bytes are unchanged. All 339 affected aggregation
tests, scoped precommit checks, warning checks, and independent review pass.
##########
compatibility-verifier/tdigest-compatibility/generate-rank-errors.sh:
##########
@@ -0,0 +1,75 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Regenerate with the pinned legacy utility and 3.3 jar, then compare all case
keys, inputs and rank errors.
+# Use --update to replace the checked-in reference after intentionally
changing the seeded input corpus.
+set -euo pipefail
+# Match the unit-test workflow's Maven Central retry and connection settings,
including standalone runs.
+export MAVEN_OPTS="${MAVEN_OPTS:-}
-Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
+-Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false
-Dmaven.wagon.http.pool=false"
+TDIGEST_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+# CI checks this pinned reference on Ubuntu x86_64 with Temurin 25; see
../README.md for portability limits.
+TDIGEST_BASELINE=f818bae6d75a91228eb3aac95c921bca4aeb2128
+TDIGEST_WORK="$TDIGEST_ROOT/pinot-segment-local/target/tdigest-rank-oracle"
+TDIGEST_JAR_DIR="$TDIGEST_ROOT/pinot-segment-local/target/tdigest-legacy-reader"
+TDIGEST_JAR="$TDIGEST_JAR_DIR/t-digest-3.3.jar"
+TDIGEST_REFERENCE="$TDIGEST_ROOT/pinot-core/src/test/resources/data/tdigest-3.3-k1-rank-errors.csv"
+mkdir -p "$TDIGEST_WORK" "$TDIGEST_JAR_DIR"
+if ! git -C "$TDIGEST_ROOT" cat-file -e "$TDIGEST_BASELINE^{commit}"
2>/dev/null; then
+ # Keep shallow CI checkouts bounded without making a developer's full clone
shallow.
+ TDIGEST_FETCH_ARGS=(--no-tags)
+ if [[ "$(git -C "$TDIGEST_ROOT" rev-parse --is-shallow-repository)" == true
]]; then
+ TDIGEST_FETCH_ARGS+=(--depth=1)
+ fi
+ for TDIGEST_ATTEMPT in 1 2 3; do
+ if git -C "$TDIGEST_ROOT" -c http.lowSpeedLimit=1 -c http.lowSpeedTime=30 \
+ fetch "${TDIGEST_FETCH_ARGS[@]}" https://github.com/apache/pinot.git
"$TDIGEST_BASELINE"; then
+ break
+ fi
+ if [[ "$TDIGEST_ATTEMPT" == 3 ]]; then
+ exit 1
+ fi
+ sleep "$((TDIGEST_ATTEMPT * 5))"
+ done
+fi
+git -C "$TDIGEST_ROOT" show \
+
"$TDIGEST_BASELINE:pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TDigestUtils.java"
\
+ > "$TDIGEST_WORK/TDigestUtils.java"
+if [[ ! -s "$TDIGEST_JAR" ]]; then
+ "$TDIGEST_ROOT/mvnw" -f "$TDIGEST_ROOT/pom.xml" -N -B -ntp \
Review Comment:
Fixed in `cda0e45cc8131a1eb86ed53da7344b202c1e22f8`: legacy-jar resolution
now uses a generated parentless standalone POM. Verified with an initially
empty Maven repository, empty user/global settings, and no cached target JAR:
dependency:copy succeeded without any installed Pinot artifacts, then all 270
frozen accuracy cases passed. The downloaded JAR and checked-in baseline
checksums are unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
