Jackie-Jiang commented on code in PR #19828:
URL: https://github.com/apache/pinot/pull/19828#discussion_r4264964349
##########
pom.xml:
##########
@@ -218,7 +218,7 @@
<libthrift.version>0.25.0</libthrift.version>
<log4j.version>2.26.1</log4j.version>
<slf4j.version>2.0.20</slf4j.version>
- <netty.version>4.1.139.Final</netty.version>
+ <netty.version>4.2.18.Final</netty.version>
Review Comment:
The latest is 4.2.19.Final
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java:
##########
@@ -137,6 +138,10 @@ public void start() {
protected void initChannel(SocketChannel ch) {
_allChannels.put(ch, true);
ch.closeFuture().addListener(f -> _allChannels.remove(ch));
+ if (_shuttingDown) {
Review Comment:
Should we just check before putting it into channels?
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/TlsUtils.java:
##########
@@ -342,8 +342,10 @@ public static SslContext buildClientContext(TlsConfig
tlsConfig) {
SSLFactory sslFactory =
RenewableTlsUtils.createSSLFactoryAndEnableAutoRenewalWhenUsingFileStores(
tlsConfig, PinotInsecureMode::isPinotInInsecureMode);
- SslContextBuilder sslContextBuilder =
-
SslContextBuilder.forClient().sslProvider(SslProvider.valueOf(tlsConfig.getSslProvider()));
+ // Keep Pinot's existing TLS behavior: verify certificate trust without
hostname verification.
+ // Netty 4.2 enables hostname verification by default, which requires a
peer hostname.
+ SslContextBuilder sslContextBuilder = SslContextBuilder.forClient()
+
.sslProvider(SslProvider.valueOf(tlsConfig.getSslProvider())).endpointIdentificationAlgorithm(null);
Review Comment:
(nit) Format seems incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
