xiangfu0 commented on code in PR #19828:
URL: https://github.com/apache/pinot/pull/19828#discussion_r4265391161
##########
pom.xml:
##########
@@ -218,7 +218,7 @@
<libthrift.version>0.25.0</libthrift.version>
<log4j.version>2.26.1</log4j.version>
<slf4j.version>2.0.20</slf4j.version>
- <netty.version>4.1.139.Final</netty.version>
+ <netty.version>4.2.18.Final</netty.version>
Review Comment:
Confirmed: pinned ZooKeeper 3.9.6 does not clear Netty 4.2’s client HTTPS
endpoint-identification default, so its configured hostnameVerification=false
is ignored for a trusted mismatched SAN. This is separate from PinotTlsUtils
and is not fixed by this PR’s transport-context reset.
I submitted the minimal upstream master fix as apache/zookeeper#2474: one
client-builder reset plus enabled/disabled cases in the existing DNS/IP × FIPS
mismatch test. Actual compiled ZooKeeper at runtime Netty 4.2.19 passes all
eight cases with JDK TLS and all eight with Netty tcnative/BoringSSL;
unmodified production controls fail exactly the four disabled-policy cases per
provider. Session and actual hostname CertificateException/engine logs
corroborate the result. All 12 existing positive provider/FIPS/policy cases
also pass. Existing negative assertion failures were reproduced on unmodified
source and retained; full upstream CI is not certified.
That upstream draft is not a published dependency fix. Pinot still pins
3.9.6, so I’m keeping this thread open and retaining the release/publication
prerequisite before claiming complete Netty 4.2 compatibility. No global Netty
default override or vendor-class shadowing was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
