J-HowHuang commented on code in PR #19861:
URL: https://github.com/apache/pinot/pull/19861#discussion_r4280358115
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/ControllerJobStatusResource.java:
##########
@@ -92,15 +92,21 @@ public String
reloadJobStatus(@PathParam("tableNameWithType") String tableNameWi
}
}
+ ReloadJobStatus jobStatus = reloadJobId != null ?
_serverReloadJobStatusCache.getJobStatus(reloadJobId) : null;
+ if (jobStatus != null) {
+ // Segments skipped by an only-if-needed reload keep their old load
time but are up to date, so they count as
+ // successful. Cap at the total in case a skipped segment was reloaded
again by a later operation.
+ successCount = (int) Math.min(successCount +
jobStatus.getSkippedCount(), totalSegmentCount);
Review Comment:
makes sense. segment names are tracked per job and only count towards
success if skipped and reloaded after the submission time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
