J-HowHuang commented on code in PR #19861:
URL: https://github.com/apache/pinot/pull/19861#discussion_r4280725659
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableReloadResource.java:
##########
@@ -77,6 +77,10 @@
@Path("/")
public class PinotTableReloadResource {
private static final Logger LOG =
LoggerFactory.getLogger(PinotTableReloadResource.class);
+ private static final String ONLY_IF_NEEDED_DESCRIPTION = "Reload only the
segments whose loaded copy is out of "
+ + "date (CRC changed, tier changed, or index/schema preprocessing
needed); up-to-date segments are skipped and "
+ + "counted as successful. Changes that only apply at load time still
require a full reload. Ignored when "
Review Comment:
I think it's good to simply remove this line. Most of the time the reload
requirement comes from downstream implementation and they can document on their
own when to use this flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
