xiangfu0 commented on code in PR #19886:
URL: https://github.com/apache/pinot/pull/19886#discussion_r4288268044
##########
pinot-tools/src/main/resources/examples/batch/colocated/userFactEvents/userFactEvents_offline_table_config.json:
##########
@@ -29,9 +24,19 @@
"instancePartitionsMap": {
"OFFLINE": "userAttributes_OFFLINE"
},
+ "segmentAssignmentConfigMap": {
Review Comment:
MINOR: Nice migration. Dropping `replicaGroupStrategyConfig` here is safe
because this table uses a pre-configured `instancePartitionsMap`
(userAttributes_OFFLINE), so `InstanceAssignmentConfigUtils` never hits the
default-generation path that reads
`partitionColumn`/`numInstancesPerPartition`. The new
`segmentAssignmentStrategy: replicaGroup` is exactly what
`allowInstanceAssignment` checks for OFFLINE replica-group assignment. No
behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
