xiangfu0 commented on code in PR #19886:
URL: https://github.com/apache/pinot/pull/19886#discussion_r4288272617
##########
pinot-tools/src/main/java/org/apache/pinot/tools/BootstrapTableTool.java:
##########
@@ -274,6 +274,9 @@ private void updatedTableConfig(TableConfig tableConfig,
File setupTableTmpDir)
throws Exception {
final List<Map<String, String>> batchConfigsMaps =
tableConfig.getIngestionConfig().getBatchIngestionConfig().getBatchConfigMaps();
+ if (batchConfigsMaps == null) {
+ return;
Review Comment:
MINOR: Good catch adding this guard. It's needed now because the migrated
configs introduce a `batchIngestionConfig` that only sets
`segmentIngestionType` with no `batchConfigMaps`, so the caller's
`getBatchIngestionConfig() != null` check passes while `getBatchConfigMaps()`
returns null here. Silently returning is fine for this bootstrap path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
