siddharthteotia opened a new pull request #4878: Use Files.createDirectories instead of File.mkdirs in TarGzCompressionUtils URL: https://github.com/apache/incubator-pinot/pull/4878 This will help in seeing the actual exception that happens in IO layer if for some reason the creation of directories fails. mkdirs() returns false and throws only SecurityException and thus we are unlikely tosee what went wrong in the underlying storage/FS. We recently had a production issue where the underlying NAS in controllers went bad and almost all operations on mount point weren't working or hanging. While debugging and incrementally fixing the problem, it was hard to figure out from the controller logs why creation of directories is failing on the mount point as mkdirs() returns false upon failure and we throw IllegalStateException which doesn't help when trying to understand what went wrong in the storage/IO layer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
