codecov-io edited a comment on issue #4850: Clean up the connection-pool based broker routing URL: https://github.com/apache/incubator-pinot/pull/4850#issuecomment-557717766 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=h1) Report > Merging [#4850](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3ec7548cd1a5abbebd32cb2fc28fdd229e47a2fa?src=pr&el=desc) will **increase** coverage by `20.65%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4850 +/- ## ============================================= + Coverage 36% 56.66% +20.65% - Complexity 0 4 +4 ============================================= Files 1207 1174 -33 Lines 64756 62568 -2188 Branches 9407 9179 -228 ============================================= + Hits 23316 35454 +12138 + Misses 39371 24484 -14887 - Partials 2069 2630 +561 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `67.58% <ø> (-1.29%)` | `0 <0> (ø)` | | | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `32.69% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `83.67% <100%> (-2.3%)` | `0 <0> (ø)` | | | [...org/apache/pinot/server/starter/ServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJCdWlsZGVyLmphdmE=) | `81.57% <50%> (+6.57%)` | `0 <0> (ø)` | :arrow_down: | | [...on/src/main/java/org/apache/pinot/serde/SerDe.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJkZS9TZXJEZS5qYXZh) | `0% <0%> (-40%)` | `0% <0%> (ø)` | | | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/common/metrics/MetricsHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NZXRyaWNzSGVscGVyLmphdmE=) | `48.75% <0%> (-12.5%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `53.65% <0%> (-7.32%)` | `0% <0%> (ø)` | | | [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `94.05% <0%> (-0.55%)` | `0% <0%> (ø)` | | | ... and [575 more](https://codecov.io/gh/apache/incubator-pinot/pull/4850/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=footer). Last update [3ec7548...4a2b43b](https://codecov.io/gh/apache/incubator-pinot/pull/4850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
