Jackie-Jiang commented on code in PR #19931:
URL: https://github.com/apache/pinot/pull/19931#discussion_r4317273914
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutorTest.java:
##########
@@ -58,24 +52,11 @@ public void setUpClass() {
}
@BeforeMethod
Review Comment:
Do we need it to be per method given there is no tear down?
Per convention, we usually call per class one `setUp()`, and per method one
`setUpMethod()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
