xiangfu0 commented on code in PR #19931:
URL: https://github.com/apache/pinot/pull/19931#discussion_r4319189550
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutorTest.java:
##########
@@ -58,24 +52,11 @@ public void setUpClass() {
}
@BeforeMethod
Review Comment:
Combined mock initialization and executor construction in one `@BeforeClass
setUp()` in 514c664620. All 14 tests call stateless helpers without mutating
the executor or shared mocks, so per-method reinitialization is unnecessary.
All 14 tests and the affected-module formatting, style, and license checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
