This is an automated email from the ASF dual-hosted git repository.
xiangfu0 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1ea404bda57 Remove unused upsert compact merge executor test
scaffolding (#19931)
1ea404bda57 is described below
commit 1ea404bda572091ed4dbd187a053b2f8f3fd3c40
Author: Xiang Fu <[email protected]>
AuthorDate: Mon Oct 19 17:38:47 2026 -0700
Remove unused upsert compact merge executor test scaffolding (#19931)
* Remove unused upsert compact merge executor test scaffolding
* Initialize upsert executor test fixture once per class
---
.../UpsertCompactMergeTaskExecutorTest.java | 47 +---------------------
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutorTest.java
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutorTest.java
index fbb03fb3028..45c9979a7c1 100644
---
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutorTest.java
+++
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutorTest.java
@@ -18,15 +18,11 @@
*/
package org.apache.pinot.plugin.minion.tasks.upsertcompactmerge;
-import java.io.File;
-import java.io.IOException;
-import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.NoSuchElementException;
-import org.apache.commons.io.FileUtils;
import org.apache.pinot.core.common.MinionConstants;
import org.apache.pinot.minion.MinionConf;
import org.apache.pinot.minion.event.MinionEventObserver;
@@ -35,16 +31,13 @@ import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.testng.Assert;
-import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeClass;
-import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
public class UpsertCompactMergeTaskExecutorTest {
private UpsertCompactMergeTaskExecutor _taskExecutor;
- private File _tempDir;
@Mock
private MinionConf _minionConf;
@@ -53,29 +46,12 @@ public class UpsertCompactMergeTaskExecutorTest {
private MinionEventObserver _eventObserver;
@BeforeClass
- public void setUpClass() {
+ public void setUp() {
MockitoAnnotations.openMocks(this);
- }
-
- @BeforeMethod
- public void setUp()
- throws Exception {
- _tempDir = new File(FileUtils.getTempDirectory(),
- "UpsertCompactMergeTaskExecutorTest_" + System.currentTimeMillis());
- FileUtils.forceMkdir(_tempDir);
-
_taskExecutor = new UpsertCompactMergeTaskExecutor(_minionConf);
_taskExecutor.setMinionEventObserver(_eventObserver);
}
- @AfterMethod
- public void tearDown()
- throws IOException {
- if (_tempDir != null && _tempDir.exists()) {
- FileUtils.deleteDirectory(_tempDir);
- }
- }
-
@Test
public void testValidateCRCForInputSegments() {
SegmentMetadataImpl segment1 = Mockito.mock(SegmentMetadataImpl.class);
@@ -256,25 +232,4 @@ public class UpsertCompactMergeTaskExecutorTest {
result = _taskExecutor.getMaxZKCreationTimeFromConfig(configs);
Assert.assertEquals(result, 1L);
}
-
- // Helper methods for testing
-
- /// Creates simple test segments (for backward compatibility with existing
tests).
- private List<File> createTestSegments()
- throws IOException {
- List<File> segmentDirs = new ArrayList<>();
-
- for (int i = 0; i < 2; i++) {
- File segmentDir = new File(_tempDir, "segment" + i);
- FileUtils.forceMkdir(segmentDir);
-
- // Create dummy metadata file
- File metadataFile = new File(segmentDir, "metadata.properties");
- FileUtils.writeStringToFile(metadataFile, "segment.name=segment" + i +
"\n");
-
- segmentDirs.add(segmentDir);
- }
-
- return segmentDirs;
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
