xiangfu0 opened a new pull request, #19977: URL: https://github.com/apache/pinot/pull/19977
Backports #19972 and #19974 to `release-1.6.0-rc`. SMART aggregation responses report actual approximation through `approximatedResult`, with the matching metric and query-log field. The MSE rewrite runs after CASE-to-FILTER conversion so conditional distinct counts retain correct NULL handling. Approximate rewriting remains disabled by default. Branch adaptations preserve the existing percentile implementation and response fields, add required test imports, and reserve the four intervening upstream enum keys so metadata IDs and stat ordinals match master. This PR stays draft until both upstream PRs are reviewed and merged, and the mixed-version protocol issue is resolved: older StatMap/DataTable readers fail on the new keys when an explicit or rewritten SMART function returns an approximate result. Matching upstream wire identities does not make those older readers compatible. Validation: 230 focused unit/planner/runtime/broker tests and all 7 `ApproximateFunctionOverrideIntegrationTest` cases passed, covering both engines, with no failures or skips. All four affected-module quality checks passed. Normal JDK 25 reactor compilation passed; additional deprecation diagnostics retain the existing zstd-jni annotation limitation described in #19976. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
