xiangfu0 opened a new pull request, #20025:
URL: https://github.com/apache/pinot/pull/20025

   ## Summary
   Fixes the intermittent 
`WindowFunnelTest.testFunnelCompleteCountGroupByQueries(boolean)[1]` failure 
(`expected [40] but found [36]`) in the custom integration suite.
   
   ## Cause
   After a segment comes online, the broker routes it as an optional new 
segment until it processes the external view change. The single-stage engine 
still queries optional segments, so the `COUNT(*)` in `waitForAllDocsLoaded` is 
already complete. The multi-stage engine skips them, because `WorkerManager` 
uses only the regular segments. The test is the first in its class, so its 
multi-stage query could run before the broker caught up and miss one segment, 
which holds 4 users.
   
   ## Fix
   `CustomDataQueryClusterIntegrationTest.waitForAllDocsLoaded(tableName, 
timeoutMs)` also waits until the broker's 
`/debug/routingTableWithOptionalSegments` shows no optional segments for the 
table. Classes that override `waitForAllDocsLoaded(timeoutMs)` keep their own 
wait.
   
   ## Tests
   `WindowFunnelTest` and `CLPEncodingRealtimeTest`, run locally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to