xiangfu0 commented on code in PR #20025:
URL: https://github.com/apache/pinot/pull/20025#discussion_r4365922133
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/CustomDataQueryClusterIntegrationTest.java:
##########
@@ -118,6 +120,32 @@ public void setUp()
LOGGER.warn("Finished setting up integration test class: {}",
getClass().getSimpleName());
}
+ /// Also waits until the broker routes every segment of the table as a
regular segment. Right after a segment comes
+ /// online, the broker can still route it as an optional new segment, which
the single-stage document count includes
+ /// but the multi-stage engine skips.
+ @Override
+ protected void waitForAllDocsLoaded(String tableName, long timeoutMs) {
Review Comment:
Minor: this gives the optional-segments wait a fresh full `timeoutMs` after
`super` may have already spent up to `timeoutMs`, so the method can block for
~2x the timeout in the worst case. Fine in practice, just noting it in case
you'd rather share one budget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
