xiangfu0 commented on PR #19998: URL: https://github.com/apache/pinot/pull/19998#issuecomment-6508611272
Thanks for the consolidated review. I pushed 92e17aaeba: sidecar generation now uses one parsed `PropertiesConfiguration` for the eager metadata and encoding, and copy-based reload skips root `.segment_metadata.*.tmp` files while retaining the valid sidecar. The focused tests passed (15 `SegmentMetadataImplTest` and 5 `SegmentLocalFSDirectoryTest` cases), along with affected Spotless, Checkstyle, license, and test compilation checks. This removes one rebuild parse, but does not yet reuse the loader's existing eager object: that object has no parse-time source fingerprint, so it could be stale relative to the fingerprint taken during rebuild. Safe cleanup of orphan temp files in the live source directory still needs writer ownership or locking; deleting by name or age could remove another active writer's file. I am leaving those points, the representation discussion, and the serving-performance measurements open. Hosted CI has restarted on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
