gortiz commented on PR #20061: URL: https://github.com/apache/pinot/pull/20061#issuecomment-6522023564
I pushed b1523f26fa on top of e4fc71fb4f with a few follow-ups from another review pass: - `auto` now plans the query again only when it groups by `ARRAY_TO_MV(expr)`. Other validation failures keep the error from master. If the second plan also fails, its error is thrown with the first one as suppressed. - `EXPLAIN PLAN WITHOUT IMPLEMENTATION` plans again only on an `ArrayToMvValidationException`. Any other error keeps the logical plan, as before. - The `HAVING` fix is narrower now. `PinotFilterAggregateTransposeRule` replaces the operand predicate: conditions on `ARRAY_TO_MV` keys stay above the aggregate, and conditions on scalar keys are still pushed below it. `MvAggregate.json` has a mixed `HAVING` case. - The null-handling cases in `MvAggregate.json` match master, but master gives the wrong answer there with null handling on. I marked them as such in the test and in the description, and I plan to fix that in a follow-up. I also updated the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
