codecov-io edited a comment on issue #4888: Refactor file format based RecordReader constructors URL: https://github.com/apache/incubator-pinot/pull/4888#issuecomment-561890160 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=h1) Report > Merging [#4888](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c93c5235d1a6e69ff65b545e319948d92c1186eb?src=pr&el=desc) will **increase** coverage by `7.03%`. > The diff coverage is `78.87%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4888 +/- ## ============================================ + Coverage 49.64% 56.67% +7.03% - Complexity 50 53 +3 ============================================ Files 1175 1175 Lines 62637 62792 +155 Branches 9181 9208 +27 ============================================ + Hits 31098 35590 +4492 + Misses 29119 24562 -4557 - Partials 2420 2640 +220 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...inot/hadoop/job/mappers/SegmentCreationMapper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtYmF0Y2gtaW5nZXN0aW9uL3Bpbm90LWhhZG9vcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvaGFkb29wL2pvYi9tYXBwZXJzL1NlZ21lbnRDcmVhdGlvbk1hcHBlci5qYXZh) | `1.09% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../java/org/apache/pinot/tools/HybridQuickstart.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL0h5YnJpZFF1aWNrc3RhcnQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/tools/admin/command/GenerateDataCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvR2VuZXJhdGVEYXRhQ29tbWFuZC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/tools/data/generator/DataGeneratorSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2RhdGEvZ2VuZXJhdG9yL0RhdGFHZW5lcmF0b3JTcGVjLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/pinot/core/minion/BackfillDateTimeColumn.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vQmFja2ZpbGxEYXRlVGltZUNvbHVtbi5qYXZh) | `56.25% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (?)` | | | [.../org/apache/pinot/hadoop/io/PinotOutputFormat.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtYmF0Y2gtaW5nZXN0aW9uL3Bpbm90LWhhZG9vcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvaGFkb29wL2lvL1Bpbm90T3V0cHV0Rm9ybWF0LmphdmE=) | `56.47% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../segment/converter/PinotSegmentConvertCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3NlZ21lbnQvY29udmVydGVyL1Bpbm90U2VnbWVudENvbnZlcnRDb21tYW5kLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...inot/tools/admin/command/CreateSegmentCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQ3JlYXRlU2VnbWVudENvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...segment/converter/ColumnarToStarTreeConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3NlZ21lbnQvY29udmVydGVyL0NvbHVtbmFyVG9TdGFyVHJlZUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [294 more](https://codecov.io/gh/apache/incubator-pinot/pull/4888/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=footer). Last update [c93c523...b603302](https://codecov.io/gh/apache/incubator-pinot/pull/4888?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
