anuragrai16 commented on code in PR #19529:
URL: https://github.com/apache/pinot/pull/19529#discussion_r4534521641


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamDataDecoder.java:
##########
@@ -28,4 +31,11 @@ public interface StreamDataDecoder {
   /// @param message [StreamMessage] that contains the data payload and 
optionally, a key and row metadata
   /// @return [StreamDataDecoderResult] that either contains the decoded row 
or the exception
   StreamDataDecoderResult decode(StreamMessage message);
+
+  /// @return the wrapped value [StreamMessageDecoder], or `null` if 
unavailable. Lets callers report the concrete
+  ///         decoder class without every implementation needing to support it.
+  @Nullable
+  default StreamMessageDecoder getValueDecoder() {

Review Comment:
   Agree, dropped the SPI method. We now records the class name when it creates 
the decoder and `pinot-spi `is unchanged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to