mcvsubbu commented on a change in pull request #4914: [POC] By-passing
deep-store requirement for Realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360602472
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -257,21 +280,78 @@ public void downloadAndReplaceSegment(String
segmentName, LLCRealtimeSegmentZKMe
final File segmentFolder = new File(_indexDir, segmentName);
FileUtils.deleteQuietly(segmentFolder);
try {
-
SegmentFetcherFactory.getInstance().getSegmentFetcherBasedOnURI(uri).fetchSegmentToLocal(uri,
tempFile);
- _logger.info("Downloaded file from {} to {}; Length of downloaded file:
{}", uri, tempFile, tempFile.length());
+ boolean downloadResult = downloadFromURI(uri, tempFile);
Review comment:
why not create a peer-download segment fetcher, initialize it only in
pinot-servers (not in controllers or minions)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
