mcvsubbu commented on a change in pull request #4914: [POC] By-passing
deep-store requirement for Realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r360600932
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -396,7 +398,7 @@ public String
segmentCommitEndWithMetadata(@QueryParam(SegmentCompletionProtocol
requestParams.withInstanceId(instanceId).withSegmentName(segmentName).withOffset(offset)
.withSegmentLocation(segmentLocation).withSegmentSizeBytes(segmentSizeBytes)
.withBuildTimeMillis(buildTimeMillis).withWaitTimeMillis(waitTimeMillis).withNumRows(numRows)
- .withMemoryUsedBytes(memoryUsedBytes);
+
.withMemoryUsedBytes(memoryUsedBytes).withSegmentUploadToController(segmentUpload);
Review comment:
You need to change all the places in this file where
CommitingSegmentDescriptor is populated, to make sure that it sets the correct
URL (whether it is vip-based, or the URL based on what is reported in the split
commit last phase)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
