kishoreg commented on a change in pull request #4956: Make plugin manager to
load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362985904
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
##########
@@ -28,19 +28,89 @@
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class PluginManager {
+ public static final String PLUGINS_DIR_ENV_VAR = "plugins.dir";
Review comment:
we are looking for these in system property not env. Let's just call it
PLUGINS_DIR_PROPERTY_NAME.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
